combinator Issue Tracker Rss Feed

Closed Issue: image-sprites branch unable to process bootstrap.css [48]

Piedone — Mon, 06 May 2013 14:23:15 GMT

Using the latest from your image-sprites branch, I'm getting the wrong bundled css output. Debugged through it and found that the ExCSS library is choking on bootstrap.css. I'm attaching the original bootstrap.css, the resource.Content that gets passed into StylesheetParser.Parse() when processing bootstrap.css. And here is the error the library throws:

s.Errors
'ExCSS.Stylesheet' does not contain a definition for 'Errors' and no extension method 'Errors' accepting a first argument of type 'ExCSS.Stylesheet' could be found (are you missing a using directive or an assembly reference?)
p.Errors
Count = 3
[0]: "-- line 9 col 165: \")\" expected"
[1]: "-- line 9 col 175: \"{\" expected"
[2]: ""

The first two errors are for this part from line 29 of the original bootstrap.css: "audio:not([controls]) {" . This looks like a bug in ExCSS. I filed a bug with ExCSS: https://github.com/TylerBrinks/ExCSS/issues/8

For now I'm going to rollback to my custom fork because that works fine for me on Azure, Azure Emulator, and in non-Azure mode (and I am OK with not using sprites feature for now).

Once this works with bootstrap again I can continue helping you debug the issues I was having.
Comments: The latest 1.7 source processes Bootstrap without issues.

Closed Issue: Revise IStorageProvider usages after Orchard 1.7 release [39]

Piedone — Thu, 18 Apr 2013 19:57:43 GMT

Since it will include Exists() methods, refactor empty try-catched now used to overwrite files.

Closed Task: Change CombinatorResourceManager to use JsonConvert [51]

Piedone — Thu, 18 Apr 2013 19:57:25 GMT

Now that JSON.NET is part of Orchard's libs it would be better to use it instead.

Created Task: Change CombinatorResourceManager to use JsonConvert [51]

Piedone — Sun, 24 Feb 2013 17:21:44 GMT

Now that JSON.NET is part of Orchard's libs it would be better to use it instead.

Commented Issue: Combinator doesn't work in Azure emulator mode [46]

Piedone — Sun, 24 Feb 2013 17:20:45 GMT

See here for details and the exception that's thrown: http://orchard.codeplex.com/discussions/399765#post928218

In CombinatorResource.cs, RelativeUrl throws an exception because the first parameter is already a well formed Uri. This is because while using the Azure Storage Emulator, the "url" parameter passed into FillRequiredContext() is a well formed URI, which looks like this: http:/127.0.0.1:10000/devstoreaccount1/media/Default/Combinator/Scripts/1063579240-1.js.

I haven't tried yet, but I don't think this error will happen when in production in Azure because the blob storage URI's will not have the same Host as as the Orchard web instance. I'll ignore the error or disable combinator when running under emulator locally, but it would be really nice to fix this and be able to test my site under emulator mode with Combinator enabled.

Comments: Does the issue exists?

Commented Issue: CSS declared fonts are getting weird URI under Azure web role [47]

Piedone — Sun, 24 Feb 2013 17:20:39 GMT

Check: http://gbiamby.cloudapp.net/

My css defines a font, "League Gothic", which is part of my theme. But when I enable combinator, the browser thinks it should download the font files from blob storage instead of from my Orchard instance.

The correct URL for the fonts, which works with Combinator disabled, is this:
http://gbiamby.cloudapp.net/themes/gbiamby/styles/fonts/League_Gothic-webfont.ttf

When combinator is enabled, the browser tries to grab the fonts from URL's like this:
http://giscard.blob.core.windows.net/Themes/gbiamby/Styles/fonts/League_Gothic-webfont.ttf
Comments: Does the issue exists?

Closed Issue: Doesn't work in multiple server set up. [41]

Piedone — Sun, 24 Feb 2013 17:19:28 GMT

Me again :)

So the code doesn't seem to work in our set up, so we have two Orchard instances, I load one with Combinator enabled, I have added ./less to my ignore paths.

The first server will create the links as follows.

<link href="/Media/Combinator/Styles/1489901916-1.css?timestamp=129839682310000000" rel="stylesheet" type="text/css" />
<link href="/Themes/ThemeName/styles/styles.less?timestamp=129839682310000000" rel="stylesheet" type="text/css" />
<link href="/Media/Combinator/Styles/1489901916-3.css?timestamp=129839682330000000" rel="stylesheet" type="text/css" />
<link href="/Media/Combinator/Styles/1489901916-4.css?timestamp=129839682340000000" rel="stylesheet" type="text/css" />

I then load up the second server.

<link href="/Media/Combinator/Styles/1489901916-1.css?timestamp=129839682310000000" rel="stylesheet" type="text/css" />
<link href="https://10.20.2.132/Themes/ThemeName/styles/styles.less" rel="stylesheet" type="text/css" />
<link href="/Media/Combinator/Styles/1489901916-3.css?timestamp=129839682330000000" rel="stylesheet" type="text/css" />
<link href="/Media/Combinator/Styles/1489901916-4.css?timestamp=129839682340000000" rel="stylesheet" type="text/css" />

Where the interal IP Address is the first server I loaded it up from, so as a outside user, this link will never work.

(I also think you don't need the timestamp on ignored resources)

Comments: Please re-open if present.

Closed Issue: Adding multiple .css and .less [35]

Piedone — Sun, 24 Feb 2013 17:19:06 GMT

I seem to be getting the same css and less being added to a page randomly.

Clearing the cache fixes it for a while and then it comes back.

Thoughts on what it could be?

example.
<link href="/Themes/ChefAndBrewer/Styles/styles.less" rel="stylesheet" type="text/css" />
<link href="/Themes/ChefAndBrewer/Styles/styles.less" rel="stylesheet" type="text/css" />
<link href="/Themes/ChefAndBrewer/Styles/styles.less" rel="stylesheet" type="text/css" />
<link href="/Themes/ChefAndBrewer/Styles/styles.less" rel="stylesheet" type="text/css" />

Comments: Please re-open if still present.

Created Feature: Use async APIs where needed after Orchard 1.7 [50]

Piedone — Sat, 09 Feb 2013 12:15:59 GMT

With async-await it's very convenient, check where this would cause performance enhancements.

Closed Task: Better inline documentation of code [4]

Piedone — Mon, 31 Dec 2012 14:49:57 GMT

Title says it all.

Commented Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Thu, 22 Nov 2012 19:31:03 GMT

Can you please add a comma delimited list of the resources contained in each bundle? <br /><br />Either as commented out html right next to the <script> or <link> tag for the bundled resource, or commented out within the bundled resource itself. <br /><br /><br /><br />
Comments: Would you mind trying it out?

Closed Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Wed, 14 Nov 2012 17:50:01 GMT

Commented Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Wed, 14 Nov 2012 17:49:24 GMT

Edited Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Wed, 14 Nov 2012 17:49:24 GMT

Edited Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Wed, 14 Nov 2012 17:30:39 GMT

Commented Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Wed, 14 Nov 2012 17:25:49 GMT

Commented Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

TheMonarch — Wed, 14 Nov 2012 15:47:52 GMT

Can you please add a comma delimited list of the resources contained in each bundle?

Either as commented out html right next to the <script> or <link> tag for the bundled resource, or commented out within the bundled resource itself.

Comments: The use case is something that happens often; there are many different scenarios in which one would want to identify which resources are in each bundle. - I push a new build to my site in production or staging, and I want to look into an issue - I am working on an issue in development and want to compare to production - I have deployed a new build and want to make sure bundles contain changes in original resources (sometimes I have to trigger cache refresh; or sometimes issues with some machines in farm serving outdated bundles) - When I was debugging the issue a few weeks ago about resource url's within .css when running under Azure, I repeatedly had to identify which bundle to look into in order to troubleshoot the Azure blob URL problem - Right now I'm looking into a potential issue where the same page loaded with two different content id's ends up loading a completely different set of bundled resources (bundles have different names, and slightly different file sizes). - When trying to use the "resource sets" feature I also came across this difficulty. Trying to see if I had the resource sets set up the way I wanted was very hard and I eventually gave up because it took too much time to verify what was happening. Disabling minification is overall not much easier than looking through the minified bundles because it requires changing the settings through the admin (and if you are in a farm you run into issues of having to refresh the bundles on all the machines, given the new settings). It also takes extra time to wait for the settings to save, empty the cache, and change the settings back, and if you are bundling resources that you didn't write, you can't rely on the comments to identify the resources.

Commented Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

Piedone — Wed, 14 Nov 2012 12:02:39 GMT

Can you please add a comma delimited list of the resources contained in each bundle?

Either as commented out html right next to the <script> or <link> tag for the bundled resource, or commented out within the bundled resource itself.

Comments: What would be the specific use-case? BTW if you disable minification you can recognize the resources building up a bundled file, in that case if you write comments those are preserved as well (however I'm not sure this latter one will work with the image-sprites branch, as ExCSS is stripping out comments AFAI remember).

Created Issue: Feature request: diagnostics output that lists what resources are in each bundled resource [49]

TheMonarch — Tue, 13 Nov 2012 21:56:35 GMT

Commented Issue: image-sprites branch unable to process bootstrap.css [48]

Piedone — Sat, 20 Oct 2012 20:27:54 GMT

Using the latest from your image-sprites branch, I'm getting the wrong bundled css output. Debugged through it and found that the ExCSS library is choking on bootstrap.css. I'm attaching the original bootstrap.css, the resource.Content that gets passed into StylesheetParser.Parse() when processing bootstrap.css. And here is the error the library throws:

s.Errors
'ExCSS.Stylesheet' does not contain a definition for 'Errors' and no extension method 'Errors' accepting a first argument of type 'ExCSS.Stylesheet' could be found (are you missing a using directive or an assembly reference?)
p.Errors
Count = 3
[0]: "-- line 9 col 165: \")\" expected"
[1]: "-- line 9 col 175: \"{\" expected"
[2]: ""

The first two errors are for this part from line 29 of the original bootstrap.css: "audio:not([controls]) {" . This looks like a bug in ExCSS. I filed a bug with ExCSS: https://github.com/TylerBrinks/ExCSS/issues/8

For now I'm going to rollback to my custom fork because that works fine for me on Azure, Azure Emulator, and in non-Azure mode (and I am OK with not using sprites feature for now).

Once this works with bootstrap again I can continue helping you debug the issues I was having.
Comments: I tried it and indeed ExCSS fails on parsing that line (commented on the ExCSS issue as well), but according to the W3C validatator bootstrap.css is not valid!